EnricoMi commented on PR #44990:
URL: https://github.com/apache/arrow/pull/44990#issuecomment-2747407026

   > Should we do this?
   
   @wgtmac Excellent catch. This is the same pattern as what I have fixed in 
https://github.com/apache/arrow/pull/44990/files#diff-c49cc60c1aa3a00a84b72c89ce2c8f5eb5d034ed8383741def1c4ae377d62854R529-R533.
 We have to `std::move` those variables that will be deconstructed when leaving 
the current function, when using them in a lambda (I think inside the `Then` is 
also required for this pattern).
   
   I have added the outer / first `std::move`. The inner / second `std::move` 
is not needed as the `file_decryptor` is a `const` here / safe already, same 
situation as in 
https://github.com/apache/arrow/pull/44990#discussion_r1880772102.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to