EnricoMi commented on PR #44990: URL: https://github.com/apache/arrow/pull/44990#issuecomment-2749303398
Commit "Remove wipeout code, use shared_ptr instead of raw pointer" (c41246ef) consequently removes key wipe-out logic (from decrypter as well as encrypter). Properties are not mutated any more (no keys get wiped out), which makes `is_utilized`, `set_utilized` and `DeepClone` redundant. Reuse of `property` by multiple decryptors in multi-threaded environment is not an issue any more. This seems to fix our remaining encryption segfaults: https://github.com/EnricoMi/arrow/actions/runs/14039452977 All what is left are flaky tests in `TwoLevelCacheWithExpirationTest`, no segfaults, likely race-conditions. macOS 13 parquet-encryption-key-management-test - TwoLevelCacheWithExpirationTest.CleanupPeriodOk https://github.com/EnricoMi/arrow/actions/runs/14039452977/job/39305637250#step:13:821 Windows 2022 AVX2 parquet-encryption-key-management-test - TwoLevelCacheWithExpirationTest.CleanupPeriodOk https://github.com/EnricoMi/arrow/actions/runs/14039452977/job/39305637260#step:10:893 Windows MinGW64 parquet-encryption-key-management-test - TwoLevelCacheWithExpirationTest.RemoveExpiration https://github.com/EnricoMi/arrow/actions/runs/14039452977/job/39305637284#step:12:401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
