eli-schwartz commented on code in PR #45854:
URL: https://github.com/apache/arrow/pull/45854#discussion_r2014878093


##########
dev/release/02-source-test.rb:
##########
@@ -84,7 +84,12 @@ def test_csharp_git_commit_information
   def test_python_version
     source
     Dir.chdir("#{@tag_name_no_rc}/python") do
-      sh("python3", "setup.py", "sdist")
+      FileUtils.mv("dummy.git", "../.git")
+      sh("python3", "-m", "pip", "install", "build")

Review Comment:
   Given that this is part of a *testsuite*, it sounds like maybe it's trying 
to verify that the sdist contains the "correct" files? Meson directly utilizes 
the VCS to figure out what should go into an sdist, so you can simply use that 
directly. Or I suppose you can make a dummy git repo that commits all the 
files. Is that what dummy.git is?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to