eli-schwartz commented on code in PR #45854:
URL: https://github.com/apache/arrow/pull/45854#discussion_r2015370151
##########
dev/release/02-source-test.rb:
##########
@@ -84,7 +84,12 @@ def test_csharp_git_commit_information
def test_python_version
source
Dir.chdir("#{@tag_name_no_rc}/python") do
- sh("python3", "setup.py", "sdist")
+ FileUtils.mv("dummy.git", "../.git")
+ sh("python3", "-m", "pip", "install", "build")
Review Comment:
To be clear, the archive works fine for a subdirectory of a git monorepo, as
`meson dist` will pass the necessary filters to `git archive` to only export
that subdirectory. There are other C/C++ monorepos using meson like this today
(iirc, GStreamer is one of them).
It just won't do so today, if there is no git repo at all. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
