Crystrix commented on a change in pull request #9700:
URL: https://github.com/apache/arrow/pull/9700#discussion_r604547954
##########
File path: cpp/src/gandiva/function_registry_string.cc
##########
@@ -100,6 +100,10 @@ std::vector<NativeFunction> GetStringFunctionRegistry() {
kResultNullIfNull, "gdv_fn_like_utf8_utf8",
NativeFunction::kNeedsFunctionHolder),
+ NativeFunction("like", {}, DataTypeVector{utf8(), utf8(), int8()},
boolean(),
Review comment:
Int8 is used here because function
[SqlLikePatternToPcre](https://github.com/apache/arrow/blob/master/cpp/src/gandiva/regex_util.h#L33)
only supports a single-byte ASCII char as the escape character.
The change of multibyte escape character may not trivial. Maybe we can
create a new issue and another PR to implement it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
