projjal commented on a change in pull request #9700:
URL: https://github.com/apache/arrow/pull/9700#discussion_r604550069
##########
File path: cpp/src/gandiva/function_registry_string.cc
##########
@@ -100,6 +100,10 @@ std::vector<NativeFunction> GetStringFunctionRegistry() {
kResultNullIfNull, "gdv_fn_like_utf8_utf8",
NativeFunction::kNeedsFunctionHolder),
+ NativeFunction("like", {}, DataTypeVector{utf8(), utf8(), int8()},
boolean(),
Review comment:
Sure creating a different ticket to support escaping multibyte char
seems fine. I still think you should provide utf8 in the signature instead of
int8 and add a check that it is of length 1, since the argument is string type.
Or else it won't work when you call the function from java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
