corwinjoy commented on PR #7342: URL: https://github.com/apache/arrow-rs/pull/7342#issuecomment-2759782227
Looking through how this function is used and implemented, many times users just want to grab metadata and don't care about options. Furthermore, right now we have a lot of code duplication between implementations of get_metadata and get_metadata_with_options. I think that what would make sense is to reduce code duplication and have a single function like: ``` fn get_metadata(&mut self, options: Option<&ArrowReaderOptions>) -> BoxFuture<'_, Result<Arc<ParquetMetaData>>>; ``` I think this would make any applicable options explicit while streamlining the existing code. If this sounds good, I can adjust the PR and we can take a look at that idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
