arashandishgar commented on PR #45663:
URL: https://github.com/apache/arrow/pull/45663#issuecomment-2766720947
> If the new tools are needed for this and other pull requests, how about
opening a pull request for it BEFORE (not after) this and other pull requests?
I sent my commit to make our discussion more clear. The problem is that the
testing tools which are defined in `statistics_test_utils.h ` are based on the
new behaviour that the `MakeStatisticsArray` method has (which is currently
defined in` statistics.cc `and used in the `MakeStatisticsArray` method of
`RecordBath`). The problem is that when I took this issue I thought it was
solved just by implementing a depth-first search and relevant tests (like the
work that I did in the first and second commits). However, as I progressed I
figured out more codes were needed.
If I should break down this pull request into smaller ones, I suggest let's
do it in that manner.
1. Solve the problem related to `StringView` and `BinaryView` #45664 which
needs some fixes in the test case, test tools, and `MakeStatisticsArray` (the
solution with relevant tests exists in my last commit).
2. Add the `MakeStatisticsArray` method to Array, which needs the relocation
of tools and the making of some files (like the same job that I did in my third
commit), as the current algorithm for making statistics array needs some
justification (the solution exists in statistics.cc for the
`MakeStatisticsArray` method).
3. Add missing attributes. I mean this issue #45639
4. Finally, adding testing tools, I mean adding TestStatisticsArray in
statistics_test_util.h and support for nested types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
