arashandishgar commented on PR #45663: URL: https://github.com/apache/arrow/pull/45663#issuecomment-2776091150
@kou After reading a recent discussion on the [Arrow mailing list,](https://lists.apache.org/thread/3wv5v3c3mboq0ynf8zkd6rolnob0t8n8) I understand the benefit of smaller pull requests—they make the problem simpler, allowing reviewers to focus better and provide more useful feedback. Would you mind if I break this pull request into smaller ones as I had planned? > 1. Solve the problem related to `StringView` and `BinaryView` [[C++] Add StringView and BinaryView to ArrayStatistics #45664](https://github.com/apache/arrow/issues/45664) which needs some fixes in the test case, test tools, and `MakeStatisticsArray` (the solution with relevant tests exists in my last commit). > 2. Add the `MakeStatisticsArray` method to Array, which needs the relocation of tools and the making of some files (like the same job that I did in my third commit), as the current algorithm for making statistics array needs some justification (the solution exists in statistics.cc for the `MakeStatisticsArray` method). > 3. Add missing attributes. I mean this issue [[C++] implement Statistic Schema attribute in C++ #45639](https://github.com/apache/arrow/issues/45639) > 4. Finally, adding testing tools (`TestStatisticsArray` in` statistics_test_util.h`) and support for nested types. > The problem is that I use new tools for testing statistics(I have not commited yet). I'll send pull for it after this pull. BTW, sorry for my previous response. I sometimes tend to overcomplicate things for myself -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
