westonpace commented on code in PR #7366:
URL: https://github.com/apache/arrow-rs/pull/7366#discussion_r2022856567
##########
arrow-array/src/array/struct_array.rs:
##########
@@ -294,10 +294,34 @@ impl StructArray {
impl From<ArrayData> for StructArray {
fn from(data: ArrayData) -> Self {
+ let parent_offset = data.offset();
+ let parent_len = data.len();
+
let fields = data
.child_data()
.iter()
- .map(|cd| make_array(cd.clone()))
+ .map(|cd| {
+ let child_offset = cd.offset();
+ let child_len = cd.len();
+ assert!(
+ child_len >= parent_len + parent_offset,
+ "struct array has offset {} and len {} but child array
only has {} items",
Review Comment:
A good question but I do not believe this suggestion is not valid. The
child's length is "number of items after the offset" and so I do not believe we
need to consider the child offset in this calculation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
