tustvold commented on code in PR #7366:
URL: https://github.com/apache/arrow-rs/pull/7366#discussion_r2026987966
##########
arrow-array/src/array/struct_array.rs:
##########
@@ -294,10 +294,34 @@ impl StructArray {
impl From<ArrayData> for StructArray {
fn from(data: ArrayData) -> Self {
+ let parent_offset = data.offset();
+ let parent_len = data.len();
+
let fields = data
.child_data()
.iter()
- .map(|cd| make_array(cd.clone()))
+ .map(|cd| {
+ let child_offset = cd.offset();
+ let child_len = cd.len();
+ assert!(
+ child_len >= parent_len + parent_offset,
+ "struct array has offset {} and len {} but child array
only has {} items",
+ parent_offset,
+ parent_len,
+ child_len
+ );
+ // SAFETY: We have already checked that the child array has
enough items and the
Review Comment:
I think this need to also slice the child's null buffer, although I left a
comment above on how to simplify this logic - ArrayData is very fiddly to use
correctly, the less code using it the better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
