tustvold commented on PR #7371: URL: https://github.com/apache/arrow-rs/pull/7371#issuecomment-2784111064
> I was thinking the change also needs to impact anything that is used to compute a file offset (like lengths, for example)? It depends on what the length represents, if it is the length of some quantity that is expected to fit into memory, usize is perfectly valid (and arguably more correct). If it is the length of the file in its entirety then yes that needs to be `u64`. I would not expect to be changing metadata size or row group size quantities to be `u64`, for example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
