kylebarron commented on PR #7371: URL: https://github.com/apache/arrow-rs/pull/7371#issuecomment-2783969881
> there are quite a few APIs that need to be updated You mean remaining in the > And the functions like `try_parse` etc (anything with a file size) I'm not sure I follow what you're saying here. `ParquetMetaDataReader::try_parse` uses `ChunkReader`, and that already uses `u64` (in `parquet` 54). In particular, `ChunkReader::get_read` and `ChunkReader::get_bytes` already use `u64` for the `start` parameter. I don't think the `length` parameter _needs_ to use `u64`, because we'll never (I assume) be making **individual reads** of >4GB, we just need to know relatively locations in a file that could be >4GB. This is a point in favor of rolling back the [change above](https://github.com/apache/arrow-rs/pull/7371#discussion_r2025694037) as @etseidl suggested, since we'll never presumably need a suffix fetch of 4GB, and we only must use `u64` for **offsets**, which also reduces the amount of changes here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
