eric-wang-1990 commented on code in PR #2691:
URL: https://github.com/apache/arrow-adbc/pull/2691#discussion_r2036076798


##########
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##########
@@ -29,10 +29,48 @@ namespace Apache.Arrow.Adbc.Drivers.Databricks
 {
     internal class DatabricksConnection : SparkHttpConnection
     {
+        // CloudFetch configuration
+        private bool _useCloudFetch = true;
+        private bool _canDecompressLz4 = true;
+        private long _maxBytesPerFile = 20 * 1024 * 1024; // 20MB default
+
         public DatabricksConnection(IReadOnlyDictionary<string, string> 
properties) : base(properties)
         {
+            // Parse CloudFetch options from connection properties
+            if (properties.TryGetValue(DatabricksParameters.UseCloudFetch, out 
string? useCloudFetchStr) &&

Review Comment:
   Misc: Looking at other examples 
https://github.com/apache/arrow-adbc/blob/9ba6bdb8bd42e35237dadfae758419846e6c442c/csharp/src/Drivers/Apache/Hive2/HiveServer2HttpConnection.cs#L64
 seem you can use the base class method Properties.TryGetValue. Note it is the 
Properties function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to