paleolimbot commented on code in PR #7398:
URL: https://github.com/apache/arrow-rs/pull/7398#discussion_r2036110803
##########
arrow-data/src/transform/mod.rs:
##########
@@ -276,6 +276,7 @@ fn build_extend(array: &ArrayData) -> Extend {
UnionMode::Dense => union::build_extend_dense(array),
},
DataType::RunEndEncoded(_, _) => todo!(),
+ DataType::Extension(_) => unimplemented!("Extension not implemented"),
Review Comment:
Yes, the tradeoff is taking on the burden of extensibility (so that other
projects don't have to implement it separately, for example, by redefining
wrapper DataTypes or Arrays). This extra burden hasn't caused issues in Arrow
C++/pyarrow that I'm aware of but absolutely fair that it might here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
