tustvold commented on code in PR #7398:
URL: https://github.com/apache/arrow-rs/pull/7398#discussion_r2034858541
##########
arrow-data/src/transform/mod.rs:
##########
@@ -276,6 +276,7 @@ fn build_extend(array: &ArrayData) -> Extend {
UnionMode::Dense => union::build_extend_dense(array),
},
DataType::RunEndEncoded(_, _) => todo!(),
+ DataType::Extension(_) => unimplemented!("Extension not implemented"),
Review Comment:
This highlights the challenge with this approach, every kernel/function must
now be updated to accommodate this new extension type. Not only does this stand
a very high chance of regressing functionality, but also is IMO not in the
spirit of extension types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
