EnricoMi commented on code in PR #46017:
URL: https://github.com/apache/arrow/pull/46017#discussion_r2037697271
##########
cpp/src/parquet/encryption/read_configurations_test.cc:
##########
@@ -103,9 +103,9 @@ class TestDecryptionConfiguration
// This vector will hold various decryption configurations.
std::vector<std::shared_ptr<parquet::FileDecryptionProperties>>
vector_of_decryption_configurations_;
- std::string kFooterEncryptionKey_ = std::string(kFooterEncryptionKey);
- std::string kColumnEncryptionKey1_ = std::string(kColumnEncryptionKey1);
- std::string kColumnEncryptionKey2_ = std::string(kColumnEncryptionKey2);
+ SecureString kFooterEncryptionKey_ = kFooterEncryptionKey;
Review Comment:
Doesn't that hold for all `k...` members in this class
(`TestDecryptionConfiguration`) and `TestEncryptionConfiguration` as well? Is
it worth it given this are tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
