EnricoMi commented on code in PR #46017:
URL: https://github.com/apache/arrow/pull/46017#discussion_r2038094558
##########
cpp/src/parquet/encryption/file_key_wrapper.cc:
##########
@@ -113,14 +113,15 @@ KeyEncryptionKey FileKeyWrapper::CreateKeyEncryptionKey(
const std::string& master_key_id) {
std::string kek_bytes(kKeyEncryptionKeyLength, '\0');
RandBytes(reinterpret_cast<uint8_t*>(kek_bytes.data()),
kKeyEncryptionKeyLength);
+ SecureString secure_kek_bytes(std::move(kek_bytes));
Review Comment:
done
##########
cpp/src/parquet/encryption/file_key_wrapper.cc:
##########
@@ -113,14 +113,15 @@ KeyEncryptionKey FileKeyWrapper::CreateKeyEncryptionKey(
const std::string& master_key_id) {
std::string kek_bytes(kKeyEncryptionKeyLength, '\0');
RandBytes(reinterpret_cast<uint8_t*>(kek_bytes.data()),
kKeyEncryptionKeyLength);
+ SecureString secure_kek_bytes(std::move(kek_bytes));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
