WillAyd commented on code in PR #46101: URL: https://github.com/apache/arrow/pull/46101#discussion_r2039496409
########## cpp/src/arrow/meson.build: ########## @@ -264,6 +264,79 @@ else rapidjson_dep = disabler() endif +azure_dep = disabler() +gcs_dep = disabler() +s3_dep = disabler() +if needs_filesystem + arrow_filesystem_srcs = [ + 'filesystem/filesystem.cc', + 'filesystem/localfs.cc', + 'filesystem/mockfs.cc', + 'filesystem/path_util.cc', + 'filesystem/util_internal.cc', + ] + + arrow_filesystem_deps = [] + + if needs_azure + arrow_filesystem_srcs += ['filesystem/azurefs.cc'] + cmake = import('cmake') + azure_opt = cmake.subproject_options() + azure_opt.add_cmake_defines( + {'BUILD_PERFORMANCE_TESTS': 'FALSE'}, + {'BUILD_SAMPLES': 'FALSE'}, + {'BUILD_TESTING': 'FALSE'}, + {'BUILD_WINDOWS_UWP': 'TRUE'}, + {'CMAKE_UNITY_BUILD': 'FALSE'}, + {'DISABLE_AZURE_CORE_OPENTELEMETRY': 'TRUE'}, + # TODO: couldn't find any usage of this in Arrow - do we need? + # set(ENV{AZURE_SDK_DISABLE_AUTO_VCPKG} TRUE) Review Comment: Ok great - I will set to FALSE then. Should I update the CMake configuration as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org