WillAyd commented on code in PR #46101:
URL: https://github.com/apache/arrow/pull/46101#discussion_r2039500252
##########
cpp/src/arrow/meson.build:
##########
@@ -264,6 +264,79 @@ else
rapidjson_dep = disabler()
endif
+azure_dep = disabler()
+gcs_dep = disabler()
+s3_dep = disabler()
+if needs_filesystem
+ arrow_filesystem_srcs = [
+ 'filesystem/filesystem.cc',
+ 'filesystem/localfs.cc',
+ 'filesystem/mockfs.cc',
+ 'filesystem/path_util.cc',
+ 'filesystem/util_internal.cc',
+ ]
+
+ arrow_filesystem_deps = []
+
+ if needs_azure
+ arrow_filesystem_srcs += ['filesystem/azurefs.cc']
+ cmake = import('cmake')
+ azure_opt = cmake.subproject_options()
+ azure_opt.add_cmake_defines(
+ {'BUILD_PERFORMANCE_TESTS': 'FALSE'},
+ {'BUILD_SAMPLES': 'FALSE'},
+ {'BUILD_TESTING': 'FALSE'},
+ {'BUILD_WINDOWS_UWP': 'TRUE'},
+ {'CMAKE_UNITY_BUILD': 'FALSE'},
+ {'DISABLE_AZURE_CORE_OPENTELEMETRY': 'TRUE'},
+ # TODO: couldn't find any usage of this in Arrow - do we need?
+ # set(ENV{AZURE_SDK_DISABLE_AUTO_VCPKG} TRUE)
+ {'WARNINGS_AS_ERRORS': 'FALSE'},
+ )
+ azure_opt.append_compile_args('cpp', '-fPIC')
+ azure_proj = cmake.subproject('azure', options: azure_opt)
+
+ azure_dep = declare_dependency(
+ dependencies: [
+ azure_proj.dependency('azure-core'),
+ azure_proj.dependency('azure-identity'),
+ azure_proj.dependency('azure-storage-blobs'),
+ azure_proj.dependency('azure-storage-common'),
+ azure_proj.dependency('azure-storage-files-datalake'),
+ ],
+ )
+ arrow_filesystem_deps += [azure_dep]
+ endif
+
+ if needs_gcs
+ error('gcs filesystem support is not yet implemented in Meson')
+ arrow_filesystem_srcs += [
+ 'filesystem/gcsfs.cc',
+ 'filesystem/gcsfs_internal.cc',
+ ]
+ gcs_dep = dependency('google-cloud-cpp')
+ arrow_filesystem_deps += [gcs_dep]
Review Comment:
No problem at all (for gcs and s3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
