paleolimbot commented on code in PR #352:
URL: https://github.com/apache/arrow-go/pull/352#discussion_r2040356524
##########
parquet/pqarrow/schema.go:
##########
@@ -306,6 +323,11 @@ func fieldToNode(name string, field arrow.Field, props
*parquet.WriterProperties
}, fieldIDFromMeta(field.Metadata))
}
return schema.MapOf(field.Name, keyNode, valueNode,
repFromNullable(field.Nullable), fieldIDFromMeta(field.Metadata))
+ case arrow.EXTENSION:
+ extType := field.Type.(arrow.ExtensionType)
+ if extType.ExtensionName() == "parquet.variant" {
Review Comment:
This is the name that's currently in C++ too, but should this just be
"arrow.variant" to avoid having both canonical Parquet extension types and
canonical Arrow extension types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
