zeroshade commented on code in PR #352:
URL: https://github.com/apache/arrow-go/pull/352#discussion_r2040390800
##########
parquet/pqarrow/schema.go:
##########
@@ -306,6 +323,11 @@ func fieldToNode(name string, field arrow.Field, props
*parquet.WriterProperties
}, fieldIDFromMeta(field.Metadata))
}
return schema.MapOf(field.Name, keyNode, valueNode,
repFromNullable(field.Nullable), fieldIDFromMeta(field.Metadata))
+ case arrow.EXTENSION:
+ extType := field.Type.(arrow.ExtensionType)
+ if extType.ExtensionName() == "parquet.variant" {
Review Comment:
For now this isn't exported so it can't be created and isn't being
registered so it won't be utilized except in this spot. When we create a
canonical arrow extension type, I figure all the implementations would just
update and change the name?
I'm mostly just using this name to maintain compatibility with the C++ impl
for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
