tustvold commented on code in PR #319:
URL: 
https://github.com/apache/arrow-rs-object-store/pull/319#discussion_r2040702666


##########
src/client/connection.rs:
##########
@@ -108,12 +108,15 @@ impl HttpError {
                 } else if e.is_timeout() {
                     kind = HttpErrorKind::Timeout;
                 }
-                break;

Review Comment:
   I think this means that now we will potentially recategorize an error 
already categorized by hyper, this seems undesirable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to