jonkeane commented on code in PR #46124:
URL: https://github.com/apache/arrow/pull/46124#discussion_r2044392148


##########
ci/scripts/r_sanitize.sh:
##########
@@ -36,34 +36,36 @@ ncores=$(${R_BIN} -s -e 'cat(parallel::detectCores())')
 echo "MAKEFLAGS=-j${ncores}" >> ${rhome}/etc/Renviron.site
 
 # build first so that any stray compiled files in r/src are ignored
-${R_BIN} CMD build .
-${R_BIN} CMD INSTALL ${INSTALL_ARGS} arrow*.tar.gz
+${R_BIN} CMD build --no-build-vignettes --no-manual .
 
 # But unset the env var so that it doesn't cause us to run extra dev tests
 unset ARROW_R_DEV
 
 # Set the testthat output to be verbose for easier debugging
 export ARROW_R_VERBOSE_TEST=TRUE
+export _R_CHECK_FORCE_SUGGESTS_=FALSE

Review Comment:
   Since we are using check, but we also are pruning dependencies like duckdb, 
we need this. We could also _not_ prune dependencies which would be how CRAN 
runs these, but we've never have sanitizer issues on our pruned dependency 
tests (most of which skip on cran too) so I'm not super worried. It would be 
easy to add them later.



##########
ci/scripts/r_sanitize.sh:
##########
@@ -36,34 +36,36 @@ ncores=$(${R_BIN} -s -e 'cat(parallel::detectCores())')
 echo "MAKEFLAGS=-j${ncores}" >> ${rhome}/etc/Renviron.site
 
 # build first so that any stray compiled files in r/src are ignored
-${R_BIN} CMD build .
-${R_BIN} CMD INSTALL ${INSTALL_ARGS} arrow*.tar.gz
+${R_BIN} CMD build --no-build-vignettes --no-manual .

Review Comment:
   This is more like what CRAN runs anyway, so I updated while I was in this 
file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to