zanmato1984 commented on code in PR #46180:
URL: https://github.com/apache/arrow/pull/46180#discussion_r2052854613
##########
cpp/src/arrow/meson.build:
##########
@@ -371,6 +366,9 @@ if needs_json
'dependencies': [rapidjson_dep],
},
}
+
+ arrow_util_srcs += 'ipc/json_simple.cc'
Review Comment:
I'm a little confused, isn't `ipc/json_simple.cc` moved to
`util/from_json.cc`?
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -620,6 +624,11 @@ if(ARROW_WITH_OPENTELEMETRY)
target_link_libraries(${ARROW_UTIL_TARGET} PRIVATE
${ARROW_OPENTELEMETRY_LIBS})
endforeach()
endif()
+if(ARROW_WITH_RAPIDJSON)
Review Comment:
Do we still need line 930~934?
```
if(ARROW_JSON)
foreach(ARROW_IPC_TARGET ${ARROW_IPC_TARGETS})
target_link_libraries(${ARROW_IPC_TARGET} PRIVATE RapidJSON)
endforeach()
endif()
```
##########
cpp/src/arrow/acero/hash_join_node_test.cc:
##########
@@ -1397,16 +1397,16 @@ TEST(HashJoin, Dictionary) {
TestHashJoinDictionaryHelper(
JoinType::FULL_OUTER, JoinKeyCmp::EQ, parallel,
// Input
- ArrayFromJSON(utf8(), R"(["a", "c", "c", "d"])"),
+ arrow::ArrayFromJSON(utf8(), R"(["a", "c", "c", "d"])"),
Review Comment:
Maybe declaring `using arrow::ArrayFromJSON;` at the beginning of this file
will do?
##########
docs/source/cpp/api/array.rst:
##########
@@ -110,3 +110,9 @@ Utilities
:project: arrow_cpp
:members:
:undoc-members:
+
+.. _api-array-from-json:
+
+.. doxygengroup:: array-from-json
Review Comment:
Is this section ill-formed? I saw "group array-from-json" rendered out in
the output document.
<img width="758" alt="Screenshot 2025-04-21 at 13 48 15"
src="https://github.com/user-attachments/assets/be30cd8c-9ec4-4ee4-88f7-9d4071ac97d8";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
