bkietz commented on code in PR #46180:
URL: https://github.com/apache/arrow/pull/46180#discussion_r2053062823
##########
cpp/src/arrow/c/bridge_test.cc:
##########
@@ -1004,15 +1006,16 @@ TEST_F(TestArrayExport, List) {
TEST_F(TestArrayExport, ListSliced) {
{
auto factory = []() {
- return ArrayFromJSON(list(int8()), "[[1, 2], [3, null], [4, 5, 6],
null]")
+ return arrow::ArrayFromJSON(list(int8()), "[[1, 2], [3, null], [4, 5,
6], null]")
Review Comment:
Are these necessary? It seems better to include a `using` declaration at the
top of the file
##########
docs/source/cpp/arrays.rst:
##########
@@ -223,3 +227,53 @@ to some logical subsequence of the data. This is done by
calling the
:func:`arrow::Array::Slice` and :func:`arrow::ChunkedArray::Slice` methods,
respectively.
+.. _fromjson_helpers:
+
+FromJSON Helpers
+================
+
+A set of helper functions is provided for concisely creating Arrays and Scalars
+from JSON_ text. These helpers are intended to be used in examples, tests, or
+for quick prototyping and are not intended to be used where performance
matters.
+
+.. _JSON: https://en.wikipedia.org/wiki/JSON
Review Comment:
Should this be a ref to rfc8259 instead of wiki?
##########
cpp/src/arrow/util/from_json_test.cc:
##########
@@ -916,7 +914,8 @@ TEST(TestMap, IntegerMapToStringList) {
auto& key_key_builder =
checked_cast<Int16Builder&>(*key_builder.key_builder());
auto& key_item_builder =
checked_cast<Int16Builder&>(*key_builder.item_builder());
auto& item_builder = checked_cast<ListBuilder&>(*map_builder.item_builder());
- auto& item_value_builder =
checked_cast<StringBuilder&>(*item_builder.value_builder());
+ auto& item_value_builder =
+ checked_cast<class StringBuilder&>(*item_builder.value_builder());
Review Comment:
```suggestion
checked_cast<StringBuilder&>(*item_builder.value_builder());
```
Where did this change come from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
