WillAyd commented on code in PR #46062:
URL: https://github.com/apache/arrow/pull/46062#discussion_r2053108110
##########
dev/tasks/python-wheels/github.windows.yml:
##########
@@ -68,11 +68,12 @@ jobs:
@rem We can remove this workaround once we find a way to use
@rem pulled caches when build an image.
echo on
- archery docker pull --no-ignore-pull-failures
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
- if errorlevel 1 (
- archery docker build --no-pull
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022 || exit /B 1
- )
- archery docker run --no-build -e SETUPTOOLS_SCM_PRETEND_VERSION={{
arrow.no_rc_version }} %TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ @rem archery docker pull --no-ignore-pull-failures
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ @rem if errorlevel 1 (
+ @rem archery docker build --no-pull
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022 || exit /B 1
+ @rem )
+ @rem archery docker run --no-build -e
SETUPTOOLS_SCM_PRETEND_VERSION={{ arrow.no_rc_version }}
%TEST_IMAGE_PREFIX%-wheel-windows-vs2022
+ archery docker run -e SETUPTOOLS_SCM_PRETEND_VERSION={{
arrow.no_rc_version }} python-wheel-windows-vs2022
Review Comment:
It looks like this is what "fixes" the windows crossbow jobs. I don't fully
understand what is going on here, but I came across this in the comment
directly preceding this as a solution.
It seems like the windows crossbow job had a pre-existing issue with the
sequence of building an image then executing it through archery (?). I am not
sure if this PR needs to solve this or if its just a caching thing that is
expected to go away once in main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
