WillAyd commented on code in PR #46062: URL: https://github.com/apache/arrow/pull/46062#discussion_r2054091380
########## dev/release/verify-release-candidate.bat: ########## @@ -140,7 +140,7 @@ set PYARROW_WITH_PARQUET=1 set PYARROW_WITH_PARQUET_ENCRYPTION=1 set PYARROW_WITH_DATASET=1 set PYARROW_TEST_CYTHON=OFF -python setup.py build_ext --inplace --bundle-arrow-cpp bdist_wheel || exit /B 1 +python -m build --wheel --config-settings=--bundle-arrow-cpp --no-isolation . || exit /B 1 Review Comment: That works too. The documented approach for this currently uses the command line argument, but it appears that more generally in the Python documentation that env vars are the documented approach. Maybe its worth removing the CLI arguments from setuptools if the environment variable approach is the one we want to stick to (in a separate PR?) ########## dev/release/verify-release-candidate.bat: ########## @@ -140,7 +140,7 @@ set PYARROW_WITH_PARQUET=1 set PYARROW_WITH_PARQUET_ENCRYPTION=1 set PYARROW_WITH_DATASET=1 set PYARROW_TEST_CYTHON=OFF -python setup.py build_ext --inplace --bundle-arrow-cpp bdist_wheel || exit /B 1 +python -m build --wheel --config-settings=--bundle-arrow-cpp --no-isolation . || exit /B 1 Review Comment: That works too. The documented approach for this currently uses the command line argument, but it appears that more generally in the Python documentation that env vars are the favored approach. Maybe its worth removing the CLI arguments from setuptools if the environment variable approach is the one we want to stick to (in a separate PR?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
