andishgar commented on code in PR #46031:
URL: https://github.com/apache/arrow/pull/46031#discussion_r2053392050
##########
cpp/src/arrow/record_batch_test.cc:
##########
@@ -1056,11 +1080,14 @@ std::vector<RawType> StatisticsValuesToRawValues(
template <typename ValueType, typename = std::enable_if_t<std::is_same<
ArrayStatistics::ValueType,
ValueType>::value>>
-Result<std::shared_ptr<Array>> BuildArray(const std::vector<ValueType>&
values) {
+Result<std::shared_ptr<Array>> BuildArray(const std::vector<ValueType>& values,
+ const std::shared_ptr<DataType>&
array_type) {
struct Builder {
const std::vector<ArrayStatistics::ValueType>& values_;
- explicit Builder(const std::vector<ArrayStatistics::ValueType>& values)
- : values_(values) {}
+ const std::shared_ptr<DataType>& array_type;
Review Comment:
Since Apache Arrow follows Google's C++ style guidelines, which
[state](https://google.github.io/styleguide/cppguide.html#Variable_Names) that
struct member names do not require a suffix, I omit suffixes for my variable
names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
