kou commented on code in PR #46031:
URL: https://github.com/apache/arrow/pull/46031#discussion_r2053402430
##########
cpp/src/arrow/record_batch.cc:
##########
@@ -556,6 +558,21 @@ Status EnumerateStatistics(const RecordBatch&
record_batch, OnStatistics on_stat
}
return Status::OK();
}
+struct StringBuilderVisitor {
+ template <typename DataType>
+ enable_if_has_string_view<DataType, Status> Visit(const DataType&,
+ ArrayBuilder* raw_builder,
+ const std::string& value) {
+ using Builder = typename TypeTraits<DataType>::BuilderType;
+ Builder* builder = static_cast<Builder*>(raw_builder);
Review Comment:
Yes.
We may specify type explicitly not `auto` when it improves readability.
In this case, the type is known by `static_cast<>` in the same line. So it
will not improve readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
