zhuqi-lucas commented on issue #7363: URL: https://github.com/apache/arrow-rs/issues/7363#issuecomment-2820818371
It looks like the performance still need to be improved, tested locally for my mac, a lot of still slower compared to the older_push_down which without page cache: ```rust ./bench.sh compare older_push_down test_default_parquet_push_down Comparing older_push_down and test_default_parquet_push_down -------------------- Benchmark clickbench_1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ older_push_down ┃ test_default_parquet_push_down ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 0.29ms │ 0.29ms │ no change │ │ QQuery 1 │ 50.39ms │ 47.96ms │ no change │ │ QQuery 2 │ 77.56ms │ 78.10ms │ no change │ │ QQuery 3 │ 77.95ms │ 85.75ms │ 1.10x slower │ │ QQuery 4 │ 579.45ms │ 520.55ms │ +1.11x faster │ │ QQuery 5 │ 560.83ms │ 583.54ms │ no change │ │ QQuery 6 │ 0.33ms │ 0.37ms │ 1.10x slower │ │ QQuery 7 │ 63.95ms │ 57.39ms │ +1.11x faster │ │ QQuery 8 │ 718.15ms │ 730.24ms │ no change │ │ QQuery 9 │ 786.44ms │ 791.21ms │ no change │ │ QQuery 10 │ 206.47ms │ 178.59ms │ +1.16x faster │ │ QQuery 11 │ 213.81ms │ 205.09ms │ no change │ │ QQuery 12 │ 679.51ms │ 611.23ms │ +1.11x faster │ │ QQuery 13 │ 1002.85ms │ 915.22ms │ +1.10x faster │ │ QQuery 14 │ 763.19ms │ 655.43ms │ +1.16x faster │ │ QQuery 15 │ 649.33ms │ 642.34ms │ no change │ │ QQuery 16 │ 1390.12ms │ 1409.99ms │ no change │ │ QQuery 17 │ 1219.49ms │ 1296.90ms │ 1.06x slower │ │ QQuery 18 │ 2932.03ms │ 2748.39ms │ +1.07x faster │ │ QQuery 19 │ 63.44ms │ 72.62ms │ 1.14x slower │ │ QQuery 20 │ 752.05ms │ 687.70ms │ +1.09x faster │ │ QQuery 21 │ 927.06ms │ 724.69ms │ +1.28x faster │ │ QQuery 22 │ 1558.98ms │ 1284.78ms │ +1.21x faster │ │ QQuery 23 │ 3402.25ms │ 3753.29ms │ 1.10x slower │ │ QQuery 24 │ 471.04ms │ 378.47ms │ +1.24x faster │ │ QQuery 25 │ 420.43ms │ 317.64ms │ +1.32x faster │ │ QQuery 26 │ 522.57ms │ 405.79ms │ +1.29x faster │ │ QQuery 27 │ 1375.58ms │ 1144.70ms │ +1.20x faster │ │ QQuery 28 │ 8767.85ms │ 8608.97ms │ no change │ │ QQuery 29 │ 458.33ms │ 451.06ms │ no change │ │ QQuery 30 │ 689.41ms │ 662.65ms │ no change │ │ QQuery 31 │ 758.38ms │ 755.04ms │ no change │ │ QQuery 32 │ 2981.93ms │ 2424.51ms │ +1.23x faster │ │ QQuery 33 │ 2886.54ms │ 2747.83ms │ no change │ │ QQuery 34 │ 3298.54ms │ 3322.28ms │ no change │ │ QQuery 35 │ 834.81ms │ 876.42ms │ no change │ │ QQuery 36 │ 40.41ms │ 94.12ms │ 2.33x slower │ │ QQuery 37 │ 35.59ms │ 50.69ms │ 1.42x slower │ │ QQuery 38 │ 39.18ms │ 92.59ms │ 2.36x slower │ │ QQuery 39 │ 35.07ms │ 133.18ms │ 3.80x slower │ │ QQuery 40 │ 36.55ms │ 43.06ms │ 1.18x slower │ │ QQuery 41 │ 36.18ms │ 42.14ms │ 1.16x slower │ │ QQuery 42 │ 37.00ms │ 40.48ms │ 1.09x slower │ └──────────────┴─────────────────┴────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (older_push_down) │ 42401.30ms │ │ Total Time (test_default_parquet_push_down) │ 40673.29ms │ │ Average Time (older_push_down) │ 986.08ms │ │ Average Time (test_default_parquet_push_down) │ 945.89ms │ │ Queries Faster │ 15 │ │ Queries Slower │ 12 │ │ Queries with No Change │ 16 │ └───────────────────────────────────────────────┴────────────┘ -------------------- Benchmark clickbench_partitioned.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ older_push_down ┃ test_default_parquet_push_down ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 1.12ms │ 1.16ms │ no change │ │ QQuery 1 │ 25.44ms │ 27.52ms │ 1.08x slower │ │ QQuery 2 │ 54.65ms │ 60.26ms │ 1.10x slower │ │ QQuery 3 │ 56.82ms │ 61.16ms │ 1.08x slower │ │ QQuery 4 │ 484.52ms │ 482.47ms │ no change │ │ QQuery 5 │ 524.38ms │ 551.00ms │ 1.05x slower │ │ QQuery 6 │ 1.24ms │ 1.25ms │ no change │ │ QQuery 7 │ 43.00ms │ 44.17ms │ no change │ │ QQuery 8 │ 632.15ms │ 676.51ms │ 1.07x slower │ │ QQuery 9 │ 658.82ms │ 692.69ms │ 1.05x slower │ │ QQuery 10 │ 154.14ms │ 149.79ms │ no change │ │ QQuery 11 │ 183.86ms │ 173.48ms │ +1.06x faster │ │ QQuery 12 │ 664.23ms │ 619.06ms │ +1.07x faster │ │ QQuery 13 │ 916.31ms │ 897.86ms │ no change │ │ QQuery 14 │ 717.15ms │ 650.81ms │ +1.10x faster │ │ QQuery 15 │ 561.85ms │ 579.71ms │ no change │ │ QQuery 16 │ 1430.77ms │ 1388.65ms │ no change │ │ QQuery 17 │ 1249.19ms │ 1150.01ms │ +1.09x faster │ │ QQuery 18 │ 2739.07ms │ 2768.37ms │ no change │ │ QQuery 19 │ 41.63ms │ 53.35ms │ 1.28x slower │ │ QQuery 20 │ 724.72ms │ 717.24ms │ no change │ │ QQuery 21 │ 819.39ms │ 728.06ms │ +1.13x faster │ │ QQuery 22 │ 1551.09ms │ 1232.23ms │ +1.26x faster │ │ QQuery 23 │ 3565.46ms │ 3089.17ms │ +1.15x faster │ │ QQuery 24 │ 457.95ms │ 365.63ms │ +1.25x faster │ │ QQuery 25 │ 381.44ms │ 306.09ms │ +1.25x faster │ │ QQuery 26 │ 526.80ms │ 409.19ms │ +1.29x faster │ │ QQuery 27 │ 1415.36ms │ 1278.68ms │ +1.11x faster │ │ QQuery 28 │ 8528.35ms │ 8521.98ms │ no change │ │ QQuery 29 │ 401.68ms │ 389.67ms │ no change │ │ QQuery 30 │ 728.25ms │ 654.12ms │ +1.11x faster │ │ QQuery 31 │ 744.53ms │ 784.18ms │ 1.05x slower │ │ QQuery 32 │ 3257.23ms │ 2953.12ms │ +1.10x faster │ │ QQuery 33 │ 3187.75ms │ 2755.04ms │ +1.16x faster │ │ QQuery 34 │ 3735.45ms │ 3459.67ms │ +1.08x faster │ │ QQuery 35 │ 877.66ms │ 885.68ms │ no change │ │ QQuery 36 │ 26.23ms │ 83.86ms │ 3.20x slower │ │ QQuery 37 │ 23.04ms │ 39.59ms │ 1.72x slower │ │ QQuery 38 │ 21.55ms │ 80.23ms │ 3.72x slower │ │ QQuery 39 │ 22.02ms │ 124.36ms │ 5.65x slower │ │ QQuery 40 │ 21.54ms │ 32.89ms │ 1.53x slower │ │ QQuery 41 │ 21.64ms │ 30.26ms │ 1.40x slower │ │ QQuery 42 │ 23.77ms │ 28.83ms │ 1.21x slower │ └──────────────┴─────────────────┴────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (older_push_down) │ 42203.20ms │ │ Total Time (test_default_parquet_push_down) │ 39979.07ms │ │ Average Time (older_push_down) │ 981.47ms │ │ Average Time (test_default_parquet_push_down) │ 929.75ms │ │ Queries Faster │ 15 │ │ Queries Slower │ 15 │ │ Queries with No Change │ 13 │ └───────────────────────────────────────────────┴────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
