pitrou commented on code in PR #46062:
URL: https://github.com/apache/arrow/pull/46062#discussion_r2054421367


##########
ci/scripts/python_wheel_macos_build.sh:
##########
@@ -176,7 +176,7 @@ export CMAKE_PREFIX_PATH=${build_dir}/install
 export SETUPTOOLS_SCM_PRETEND_VERSION=${PYARROW_VERSION}
 
 pushd ${source_dir}/python
-python setup.py bdist_wheel
+python -m build --wheel --no-isolation .

Review Comment:
   According to https://build.pypa.io/en/stable/index.html , it's recommended 
not to pass `--wheel` so that:
   > By default, a source distribution (sdist) is built from {srcdir} and a 
binary distribution (wheel) is built from the sdist. This is recommended as it 
will ensure the sdist can be used to build wheels.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to