amoeba commented on code in PR #46180:
URL: https://github.com/apache/arrow/pull/46180#discussion_r2054471089
##########
cpp/src/arrow/util/from_json_test.cc:
##########
@@ -916,7 +914,8 @@ TEST(TestMap, IntegerMapToStringList) {
auto& key_key_builder =
checked_cast<Int16Builder&>(*key_builder.key_builder());
auto& key_item_builder =
checked_cast<Int16Builder&>(*key_builder.item_builder());
auto& item_builder = checked_cast<ListBuilder&>(*map_builder.item_builder());
- auto& item_value_builder =
checked_cast<StringBuilder&>(*item_builder.value_builder());
+ auto& item_value_builder =
+ checked_cast<class StringBuilder&>(*item_builder.value_builder());
Review Comment:
> Could you use the explicit namespace?
Changed to use the fully qualified name in
11da4d40f05e97ad744df58c3d4b0db267e6cbb0. Would it be fair to say that the
preferred options in cases like this, in order, are something like,
1. Avoid colliding names in the first place to avoid the need to
disambiguate names
2. Use namespaces and fully-qualified names to disambiguate names
3. As a last resort, use keywords like `class` was used here to help the
compiler figure it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
