rok commented on code in PR #46180: URL: https://github.com/apache/arrow/pull/46180#discussion_r2054083538
########## docs/source/cpp/arrays.rst: ########## @@ -223,3 +227,53 @@ to some logical subsequence of the data. This is done by calling the :func:`arrow::Array::Slice` and :func:`arrow::ChunkedArray::Slice` methods, respectively. +.. _fromjson_helpers: + +FromJSON Helpers +================ + +A set of helper functions is provided for concisely creating Arrays and Scalars +from JSON_ text. These helpers are intended to be used in examples, tests, or +for quick prototyping and are not intended to be used where performance matters. Review Comment: Perhaps add a comment here that Arrow has a performant JSON reader that should be used in performance-sensitive cases? Perhaps adding a link too: https://arrow.apache.org/docs/cpp/json.html ########## cpp/src/arrow/c/bridge_test.cc: ########## @@ -1004,15 +1006,16 @@ TEST_F(TestArrayExport, List) { TEST_F(TestArrayExport, ListSliced) { { auto factory = []() { - return ArrayFromJSON(list(int8()), "[[1, 2], [3, null], [4, 5, 6], null]") + return arrow::ArrayFromJSON(list(int8()), "[[1, 2], [3, null], [4, 5, 6], null]") Review Comment: Adding a `using` would be nicer here, e.g.: ```cpp using arrow::ArrayFromJSON; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
