AlenkaF commented on code in PR #46078:
URL: https://github.com/apache/arrow/pull/46078#discussion_r2055217577
##########
python/pyarrow/tests/test_fs.py:
##########
@@ -1230,7 +1230,8 @@ def test_s3_options(pickle_module):
assert pickle_module.loads(pickle_module.dumps(fs2)) == fs2
assert fs2 != fs
- fs = S3FileSystem(allow_bucket_creation=True, allow_bucket_deletion=True)
+ fs = S3FileSystem(allow_bucket_creation=True, allow_bucket_deletion=True,
+ allow_delayed_open=True)
Review Comment:
> Is this really required ? Isn't this behavior being tested at the C++
[layer](https://github.com/apache/arrow/blob/main/cpp/src/arrow/filesystem/s3fs_test.cc)
? Should we test it again on Python or _just_ make sure that the C++ API is
built correctly ( pickle.loads/pickle.dumps) ?
Agree it is already tested in C++ and not strictly necessary. But if there
is an existing Python tests for a non-existent bucket, updating it with
`allow_delayed_open` behavioural check would be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
