pitrou commented on code in PR #46078: URL: https://github.com/apache/arrow/pull/46078#discussion_r2056213810
########## python/pyarrow/tests/test_fs.py: ########## @@ -1230,6 +1230,10 @@ def test_s3_options(pickle_module): assert pickle_module.loads(pickle_module.dumps(fs2)) == fs2 assert fs2 != fs + fs = S3FileSystem(allow_delayed_open=True) + assert isinstance(fs, S3FileSystem) + assert pickle_module.loads(pickle_module.dumps(fs)) == fs Review Comment: Let's also check the option is not simply ignored ```suggestion assert pickle_module.loads(pickle_module.dumps(fs)) == fs assert pickle_module.loads(pickle_module.dumps(fs)) != S3FileSystem() ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org