kou commented on code in PR #2718:
URL: https://github.com/apache/arrow-adbc/pull/2718#discussion_r2055344114
##########
.github/workflows/nightly-verify.yml:
##########
@@ -201,3 +205,31 @@ jobs:
run: |
pushd arrow-adbc
docker compose run -e PYTHON=3.12 --rm python-debug
+
+ source-verify-docker:
+ name: "Verify Source (OS)/${{ matrix.os }} ${{ matrix.version }}"
+ runs-on: ubuntu-latest
+ strategy:
+ max-parallel: 2
+ matrix:
+ include:
+ - os: ubuntu
+ version: "22.04"
+ - os: ubuntu
+ version: "24.04"
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ path: arrow-adbc
+ persist-credentials: false
+ submodules: recursive
+
+ - name: Verify
+ env:
+ OS: ${{ matrix.os }}
+ OS_VERSION: ${{ matrix.version }}
+ run: |
+ # Hmm, -e doesn't work?
Review Comment:
Ah, I understand.
`env UBUNTU=22.04 ...` is used in `${UBUNTU}` in `compose.yaml` and `... -e
UBUNTU=22.04 ...` is used in a container created by `docker compose run`. In
this case, we want to use `${UBUNTU}` in `compose.yaml`. So we need to use `env
UBUNTU=22.04 ...` not `... -e UBUNTU=22.04 ...` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
