kou commented on code in PR #2718:
URL: https://github.com/apache/arrow-adbc/pull/2718#discussion_r2057182150
##########
dev/release/verify-release-candidate.sh:
##########
@@ -246,38 +246,42 @@ install_dotnet() {
return 0
fi
- show_info "Ensuring that .NET is installed..."
-
- if dotnet --version | grep 8\.0 > /dev/null 2>&1; then
- local csharp_bin=$(dirname $(which dotnet))
- show_info "Found C# at $(which csharp) (.NET $(dotnet --version))"
- else
- if which dotnet > /dev/null 2>&1; then
- show_info "dotnet found but it is the wrong version and will be ignored."
+ if command -v dotnet; then
+ show_info "Found $(dotnet --version) at $(which dotnet)"
+
+ if dotnet --version | grep 8\.0 > /dev/null 2>&1; then
Review Comment:
FYI: We can use `--fixed-string`/`-F` for this case and we can use `--quiet`
instead of redirect:
```suggestion
if dotnet --version | grep --quiet --fixed-string 8.0; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
