felipecrv commented on code in PR #2736:
URL: https://github.com/apache/arrow-adbc/pull/2736#discussion_r2056301602
##########
rust/core/src/driver_manager.rs:
##########
@@ -164,7 +164,7 @@ struct ManagedDriverInner {
/// Implementation of [Driver].
#[derive(Clone)]
pub struct ManagedDriver {
- inner: Arc<ManagedDriverInner>,
+ inner: Pin<Arc<ManagedDriverInner>>,
Review Comment:
I want to ensure the `FFI_AdbcDriver` doesn't get moved around after a
pointer is passed to the C side. Instead of wrapping `FFI_Driver` in a `Box`
(would add another pointer indirection) I pinned this `Arc` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
