felipecrv commented on PR #2736: URL: https://github.com/apache/arrow-adbc/pull/2736#issuecomment-2824677371
> Should we specify that access to the private fields of the driver > > https://github.com/apache/arrow-adbc/blob/c6e1ab5d05fae6143b7fcd22896d0bc7ac14f9d3/c/include/arrow-adbc/adbc.h#L989-L996 > > must be serialized by driver (`private_data`) and driver manager (`private_manager`) implementations? I agree. I checked some of the code and it uses these fields only for reference counts (which are atomic). It would be good to have a comment in `adbc.h` calling the need for thread-safety on accessing these fields, but there are so many copies of `adbc.h` around... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
