paleolimbot commented on PR #45459: URL: https://github.com/apache/arrow/pull/45459#issuecomment-2826346276
I think this is ready for another round when time allows! A few notes: - @jorisvandenbossche mentioned in a recent GeoParquet sync that it might be nice if the GEOMETRY type was written even if the type was not registered (i.e., only field metadata were present). I'd like to avoid that in this PR just because it's also a change with respect to the other types we currently handle. - The bounding boxes I believe are synced with our discussion at https://github.com/apache/parquet-format/pull/494 . I opened a follow-up to ensure we can get a null count for geospatial types and I'm happy to give that a go after this merges. - The example files are written using the latest version of this, and include some Python tests. I'm happy to move the Python tests here after the example files are in parquet-testing ( https://github.com/apache/parquet-testing/pull/70 ). I know this has gotten quite large but if possible I hope this can merge relatively early in the 21.0.0 release cycle so that we (and others) can experiment with the nightly Python builds and identify issues arising from some target use cases. Let me know what any next steps are on my end! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
