kou commented on code in PR #45459:
URL: https://github.com/apache/arrow/pull/45459#discussion_r2057931531
##########
cpp/src/parquet/CMakeLists.txt:
##########
@@ -260,6 +263,14 @@ endif()
if(NOT PARQUET_MINIMAL_DEPENDENCY)
list(APPEND PARQUET_SHARED_LINK_LIBS arrow_shared)
+ # Add RapidJSON libraries
+ if(NOT ARROW_JSON)
Review Comment:
We don't need JSON if `PARQUET_MINIMAL_DEPENDENCY` is `ON`, right?
Then, we don't need the following:
```diff
diff --git a/cpp/cmake_modules/DefineOptions.cmake
b/cpp/cmake_modules/DefineOptions.cmake
index 16360929a9..93a7ba6063 100644
--- a/cpp/cmake_modules/DefineOptions.cmake
+++ b/cpp/cmake_modules/DefineOptions.cmake
@@ -370,7 +370,8 @@ takes precedence over ccache if a storage backend is
configured" ON)
"Build the Parquet libraries"
OFF
DEPENDS
- ARROW_IPC)
+ ARROW_IPC
+ ARROW_JSON)
define_option(ARROW_ORC
"Build the Arrow ORC adapter"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
