eric-wang-1990 commented on code in PR #2747:
URL: https://github.com/apache/arrow-adbc/pull/2747#discussion_r2064735879
##########
csharp/src/Drivers/Databricks/CloudFetch/CloudFetchDownloader.cs:
##########
@@ -274,14 +290,21 @@ private async Task DownloadFilesAsync(CancellationToken
cancellationToken)
catch (OperationCanceledException) when
(cancellationToken.IsCancellationRequested)
{
// Expected when cancellation is requested
+ Trace.TraceInformation("Download process was cancelled");
}
catch (Exception ex)
{
- Debug.WriteLine($"Error in download loop: {ex.Message}");
+ Trace.TraceError($"Error in download loop: {ex.Message}");
SetError(ex);
}
finally
{
+ overallStopwatch.Stop();
+
+ Trace.TraceInformation(
Review Comment:
Does these log get exposed to PowerBI in anyway?
##########
csharp/src/Drivers/Databricks/CloudFetch/CloudFetchDownloader.cs:
##########
@@ -23,6 +23,7 @@
using System.Threading;
using System.Threading.Tasks;
using K4os.Compression.LZ4.Streams;
+using Microsoft.Extensions.Logging;
Review Comment:
Seems we are using Trace.TraceError, so this import is probably not
used/needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
