CurtHagenlocher commented on code in PR #2747:
URL: https://github.com/apache/arrow-adbc/pull/2747#discussion_r2065214730
##########
csharp/src/Drivers/Databricks/CloudFetch/CloudFetchDownloader.cs:
##########
@@ -298,6 +321,12 @@ private async Task DownloadFileAsync(IDownloadResult
downloadResult, Cancellatio
// Use the size directly from the download result
long size = downloadResult.Size;
+ // Create a stopwatch to track download time
+ var stopwatch = Stopwatch.StartNew();
+
+ // Log download start
+ Trace.TraceInformation($"Starting download of file
{downloadResult.Link.FileLink} from {SanitizeUrl(url)}, expected size: {size /
1024.0:F2} KB");
Review Comment:
All of these traces incorporate both the FileLink and a sanitized version of
the url. But based on line 318, these are the same value. Is there a reason to
log both an unsanitized version and a sanitized version of the same url in each
trace message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
