Dandandan commented on a change in pull request #9882:
URL: https://github.com/apache/arrow/pull/9882#discussion_r606990935
##########
File path: rust/benchmarks/src/bin/tpch.rs
##########
@@ -1677,7 +1677,6 @@ mod tests {
let actual_vec = result_vec(&actual);
// basic result comparison
- assert_eq!(expected_vec.len(), actual_vec.len());
Review comment:
I reverted this change -> found out the test was actually wrong..
Also interesting, I thought one of the tests was giving a wrong example
(besides some rounding errors because we don't use decimals in the benchmark),
but it seems currently wrong on master too:
```
Query 6 iteration 0 took 6137.1 ms
Query 6 avg time: 6137.09 ms
thread 'tests::q6' panicked at 'assertion failed: `(left == right)`
left: `["123141078.23"]`,
right: `["75207768.18550001"]`', benchmarks/src/bin/tpch.rs:1684:17
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
