Dandandan commented on a change in pull request #9882:
URL: https://github.com/apache/arrow/pull/9882#discussion_r607570020
##########
File path: rust/datafusion/src/physical_plan/planner.rs
##########
@@ -344,13 +345,33 @@ impl DefaultPhysicalPlanner {
JoinType::Left => hash_utils::JoinType::Left,
JoinType::Right => hash_utils::JoinType::Right,
};
-
- Ok(Arc::new(HashJoinExec::try_new(
- left,
- right,
- &keys,
- &physical_join_type,
- )?))
+ if ctx_state.config.concurrency > 1 {
+ let left_expr = keys.iter().map(|x| col(&x.0)).collect();
+ let right_expr = keys.iter().map(|x| col(&x.1)).collect();
+
+ // Use hash partition by defualt to parallelize hash joins
+ Ok(Arc::new(HashJoinExec::try_new(
+ Arc::new(RepartitionExec::try_new(
Review comment:
Yeah I think I saw that happening I think in some cases when testing
with in-memory data.
We have to have a solution for that at some point to buffer only up to x
batches or x MB something like that.
I am willing to add a config for this although we might also try to reduce
the n.r. of knobs we add?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
