pitrou commented on issue #46270: URL: https://github.com/apache/arrow/issues/46270#issuecomment-2841934412
Ah, no, I actually misread the docstring and missed the "zero" which amounts to a double negative. 1) How about changing "zero non-NaN values were encountered in that dimension" to "all values in that dimension are NaN"? 2) Why would `dimension_empty()` return false if `dimension_valid()` is false? Wouldn't it be easier for the user if `dimension_empty()` also returned true in that case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
