eli-schwartz commented on code in PR #45854: URL: https://github.com/apache/arrow/pull/45854#discussion_r2069210359
########## python/MANIFEST.in: ########## @@ -1,15 +0,0 @@ -include README.md -include ../LICENSE.txt Review Comment: I patched meson (not meson-python) so that building binary artifacts and installing them with meson's SBOM generator (automatically produced and installed when passing `--licensedir=/usr/share/licenses/PyArrow/`) should correctly install the license. In principle, that's also how dynamically defined pyproject licenses get inserted into a wheel. Building a standalone `meson dist` tarball release (similar to Autotools `make distcheck`) will not try to resolve the license, at least not currently. My thoughts were that it is *obviously incorrect* to mishandle a clear directive: > license-file: ../XXX.md > install-licenses: yes and we can make this "obviously correct" so that monorepos will install correctly. But it's not immediately apparent whether or not most monorepos utilizing symlinks between different directories, expect that a single directory should also have standalone source code releases (they may only support installing from the entire monorepo workspace, or they may generate per-component binary packages from the monorepo and then tell people to install from binaries). Building source code tarballs is a totally optional thing that many people don't do (both in the C/C++ world and in the python world. When was the last time you saw a Torch sdist on PyPI? When was the last time you tried to build python-tensorflow using any kind of PyPA standards at all? If some organizational design makes it inconvenient or troublesome to do an sdist, that should never be a valid reason to unnecessarily restrict wheel creation. I'm definitely interested to hear more about solutions which monorepo users would like to see, as monorepos are a completely valid use case. But it's possible that producing an sdist from a monorepo requires designing a feature, not just fixing a bug. (Or not. I don't usually work with monorepos so I'm not an expert on designing workflows for them.) And those take longer to formulate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
