jecsand838 commented on code in PR #7451:
URL: https://github.com/apache/arrow-rs/pull/7451#discussion_r2069285439
##########
arrow-avro/src/codec.rs:
##########
@@ -155,6 +168,22 @@ impl Codec {
DataType::List(Arc::new(f.field_with_name(Field::LIST_FIELD_DEFAULT_NAME)))
}
Self::Struct(f) => DataType::Struct(f.iter().map(|x|
x.field()).collect()),
+ Self::Map(value_type) => {
+ let val_dt = value_type.codec.data_type();
+ let val_field = Field::new("value", val_dt, true)
Review Comment:
@klion26
I was attempting to follow the same pattern used in the other types such as
`ComplexType::Record(r)`, `ComplexType::Array(a)`, and `ComplexType::Fixed(f)`.
It seemed from reading the code that nullability would only be set in the
`Schema::Union(f)` branch of `make_data_type`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
