jecsand838 commented on code in PR #7451:
URL: https://github.com/apache/arrow-rs/pull/7451#discussion_r2069301291
##########
arrow-avro/src/reader/record.rs:
##########
@@ -290,3 +401,84 @@ fn flush_primitive<T: ArrowPrimitiveType>(
}
const DEFAULT_CAPACITY: usize = 1024;
+
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+ use arrow_array::{
+ cast::AsArray, Array, Decimal128Array, DictionaryArray,
FixedSizeBinaryArray,
+ IntervalMonthDayNanoArray, ListArray, MapArray, StringArray,
StructArray,
+ };
+
+ fn encode_avro_long(value: i64) -> Vec<u8> {
+ let mut buf = Vec::new();
+ let mut v = (value << 1) ^ (value >> 63);
+ while v & !0x7F != 0 {
+ buf.push(((v & 0x7F) | 0x80) as u8);
+ v >>= 7;
+ }
+ buf.push(v as u8);
+ buf
+ }
+
+ fn encode_avro_bytes(bytes: &[u8]) -> Vec<u8> {
+ let mut buf = encode_avro_long(bytes.len() as i64);
+ buf.extend_from_slice(bytes);
+ buf
+ }
+
+ fn avro_from_codec(codec: Codec) -> AvroDataType {
+ AvroDataType::new(codec, None, Default::default())
Review Comment:
@klion26 I was thinking it would be best to handle nullability in a
dedicated PR after the basic support for each type is merged in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
